Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-protoc fix missing javadoc #2144

Merged
merged 3 commits into from
Mar 10, 2022
Merged

grpc-protoc fix missing javadoc #2144

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1b710c
grpc-protoc fix missing javadoc
Scottmitch Mar 10, 2022
acd697e
review comments
Scottmitch Mar 10, 2022
632da32
`@deprecated` after `@return`
idelpivnitskiy Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion servicetalk-grpc-protoc/src/main/java/io/servicetalk/grpc/protoc/Generator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,12 @@ private TypeSpec.Builder addServiceFactory(final State state, final TypeSpec.Bui
serviceBuilderSpecBuilder.addMethod(methodBuilder(addService)
.addModifiers(PUBLIC)
.addAnnotation(Deprecated.class)
.addJavadoc(JAVADOC_DEPRECATED + "Use {@link #$L($T)}." + lineSeparator(), addBlockingService,
.addJavadoc(JAVADOC_DEPRECATED + "Use {@link #$L($T)}.", addBlockingService,
Scottmitch marked this conversation as resolved.
Show resolved Hide resolved
state.blockingServiceClass)
.addJavadoc(lineSeparator())
.addJavadoc(JAVADOC_PARAM + service + " the service to add.")
.addJavadoc(lineSeparator())
.addJavadoc(JAVADOC_RETURN + "this.")
.returns(builderClass)
.addParameter(state.blockingServiceClass, service, FINAL)
.addStatement("return $L($L)", addBlockingService, service)
Expand Down