Processors.newPublisherProcessor simplify duplicate terminal check #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Processors.newPublisherProcessor checks in the thread generating data if a terminal has already been observed, and discards duplicates. However the consumer thread also has the same logic which is required because we cannot deliver signals to the Subscriber after a terminal signal is delivered. Modifications: - Keep the required check in the queue consumer thread which filters out duplicate terminal events, remove the check in the producer thread. If there is a strict limit applied to the queue size this may impact how many items the queue needs to hold. Result: Less atomic operations, 1 less class in the hierarchy, and less memory consumed by Processors.newPublisherProcessor.
Scottmitch
commented
Mar 15, 2022
| TerminalNotification.class, "terminal"); | ||
|
|
||
| @Nullable | ||
| private volatile TerminalNotification terminal; |
There was a problem hiding this comment.
@NiteshKant - are there any hard requirements for filtering out duplicate terminals before the queue, or does this change make sense?
|
build failure attributed to #1894 |
idelpivnitskiy
approved these changes
Mar 16, 2022
|
discussed with @NiteshKant offline. got lgtm and will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Processors.newPublisherProcessor checks in the thread generating
data if a terminal has already been observed, and discards duplicates.
However the consumer thread also has the same logic which is required
because we cannot deliver signals to the Subscriber after a terminal
signal is delivered.
Modifications:
out duplicate terminal events, remove the check in the producer
thread. If there is a strict limit applied to the queue size
this may impact how many items the queue needs to hold.
Result:
Less atomic operations, 1 less class in the hierarchy, and less
memory consumed by Processors.newPublisherProcessor.