Make ServiceTalk protoc plugin extensible #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suman-ganta
force-pushed
the
service_insertion_point
branch
from
08c500a to
1c08a11
Compare
Adds plugin insertion point (comment) into servicetalk generated service classes. Motivation: When we want to enrich ServiceTalk generated service classes with additional functionality, this insertion point enables to add such code. Why is this change being made? When we want to enrich ServiceTalk generated service classes with additional functionality, this insertion point enables to add such code. Modifications: - List the changes Since JavaPoet has no way to add a comment within a class, Added an empty type as place holder and replaced it with the comment before adding the content to CodeGeneratorResponse Result: What is the result of this change? Every ServiceTalk generated service class will have following comment towards the end of the class. // @@protoc_insertion_point(service_scope:<fully qualified name of service>)
suman-ganta
force-pushed
the
service_insertion_point
branch
from
1c08a11 to
5f817ce
Compare
Scottmitch
reviewed
Apr 8, 2022
servicetalk-grpc-protoc/src/main/java/io/servicetalk/grpc/protoc/FileDescriptor.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change in one line.
Adds plugin insertion point (comment) into servicetalk generated service classes.
Motivation:
When we want to enrich ServiceTalk generated service classes with additional functionality, this insertion point enables to add such code.
Why is this change being made?
When we want to enrich ServiceTalk generated service classes with additional functionality, this insertion point enables to add such code.
Modifications:
Since JavaPoet has no way to add a comment within a class, Added an empty type as place holder and replaced it with the comment before adding the content to CodeGeneratorResponse
Result:
What is the result of this change?
Every ServiceTalk generated service class will have following comment towards the end of the class.