Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher.multicast duplicate cancel IndexOutOfBounds exception #2161

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Publisher.multicast duplicate cancel IndexOutOfBounds exception #2161

merged 1 commit into from
Mar 23, 2022

Conversation

Scottmitch
Copy link
Member

Motivation:
The Publisher.multicast operator may throw IndexOutOfBounds
exception if a Subscription is cancelled multiple times and
there are other active Subscriptions.

@Scottmitch
Publisher.multicast duplicate cancel IndexOutOfBounds exception
39681bf 
Motivation:
The Publisher.multicast operator may throw IndexOutOfBounds
exception if a Subscription is cancelled multiple times and
there are other active Subscriptions.
@Scottmitch Scottmitch added the bug Something isn't working label Mar 23, 2022
@Scottmitch Scottmitch self-assigned this Mar 23, 2022
idelpivnitskiy
idelpivnitskiy approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@Scottmitch Scottmitch merged commit 99712d1 into apple:main Mar 23, 2022
@Scottmitch Scottmitch deleted the pub_multicast_dup_cancel branch March 23, 2022 19:51
bondolo
bondolo reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@bondolo bondolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondolo bondolo bondolo left review comments

@idelpivnitskiy idelpivnitskiy idelpivnitskiy approved these changes

@chemicL chemicL Awaiting requested review from chemicL

@tkountis tkountis Awaiting requested review from tkountis

Assignees

@Scottmitch Scottmitch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scottmitch @bondolo @idelpivnitskiy