MultiAddressClientBuilder execution strategy control
#2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The `MultiAddressClientBuilder` does not currently always respect overrides of execution strategy made by the single address initializer Modification: The computed execution strategy is a combination of the multiaddress client builder strategy, the api strategy and the client strategy. Result: More predictable and controllable behavior for `MultiAddressClientBuilder`
bondolo
force-pushed
the
multiaddress-initializer-strategy
branch
from
aabc697 to
dc260f4
Compare
bondolo
requested review from
idelpivnitskiy,
chemicL,
Scottmitch and
tkountis
and removed request for
chemicL
idelpivnitskiy
previously requested changes
Apr 13, 2022
servicetalk-client-api/src/main/java/io/servicetalk/client/api/DefaultClientGroup.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/SingleAddressHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpContextKeys.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpApiConversions.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpApiConversions.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
bondolo
force-pushed
the
multiaddress-initializer-strategy
branch
from
03198b9 to
acd2535
Compare
|
Will have a final look after merge conflicts resolved |
|
Temporarily draft as pieces are pulled into separate standalone PRs. |
|
After #2192 I saw a new flaky case: |
I have switched the test to use |
bondolo
dismissed
idelpivnitskiy’s stale review
review feedback all implemented.
|
Hey, some outdated comments from intermediate iterations were published unintentionally. All of those are already resolved. Go ahead with merging the PR. Thanks for the hard work on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
MultiAddressClientBuilderdoes not currently always respectoverrides of execution strategy made by the single address
initializer
Modification:
The computed execution strategy is a combination of the multiaddress
client builder strategy, the api strategy and the client strategy.
Result:
More predictable and controllable behavior for
MultiAddressClientBuilder