LoadBalancer and ConnectionFactory: add a context of the caller
#2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `LoadBalancer` and `ConnectionFactory` API is disconnected from the caller, lacks context who/why selects/creates a connection, and has no API to propagate additional information from the caller (request). Modifications: - `LoadBalancer`: add new `selectConnection(Predicate, ContextMap)` method, deprecate `selectConnection(Predicate)`; - `ConnectionFactory`: add new `newConnection(Address, ContextMap, TransportObserver)` method, deprecate `newConnection(Address, TransportObserver)`; - Migrate all LB/CF implementations and tests to use new API; - Add `DeprecatedToNewConnectionFactoryFilter` after each user-defined CF to make sure old/new filters work in the same pipeline; Result: Information can be propagated from the caller to the `LoadBalancer` and `ConnectionFactory`.
chemicL
approved these changes
Apr 13, 2022
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jul 22, 2022
Motivation: apple#2168 add `ContextMap` for `LoadBalancer` and `ConnectionFactory`, but does not let the context go through `LoadBalancedAddress`. Modifications: - Add `LoadBalancedAddress#newConnection(ContextMap)` method; - Deprecate `LoadBalancedAddress#newConnection()`; Result: Caller context can be propagated through `LoadBalancedAddress`.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jul 22, 2022
Motivation: apple#2168 add `ContextMap` for `LoadBalancer` and `ConnectionFactory`, but does not let the context go through `LoadBalancedAddress`. Modifications: - Add `LoadBalancedAddress#newConnection(ContextMap)` method; - Deprecate `LoadBalancedAddress#newConnection()`; Result: Caller context can be propagated through `LoadBalancedAddress`.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jul 22, 2022
Motivation: apple#2168 and apple#2235 added default implementations that throw an exception. However, those method signatures return an async source. Modifications: - Return a `failed` source with an exception instead of throwing; Result: Default methods follow async contract.
idelpivnitskiy
added a commit
that referenced
this pull request
Jul 26, 2022
Motivation: #2168 add `ContextMap` for `LoadBalancer` and `ConnectionFactory`, but does not let the context go through `LoadBalancedAddress`. Modifications: - Add `LoadBalancedAddress#newConnection(ContextMap)` method; - Deprecate `LoadBalancedAddress#newConnection()`; Result: Caller context can be propagated through `LoadBalancedAddress`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
LoadBalancerandConnectionFactoryAPI is disconnected from thecaller, lacks context who/why selects/creates a connection, and has no
API to propagate additional information from the caller (request).
Modifications:
LoadBalancer: add newselectConnection(Predicate, ContextMap)method, deprecate
selectConnection(Predicate);ConnectionFactory: add newnewConnection(Address, ContextMap, TransportObserver)method,deprecate
newConnection(Address, TransportObserver);DeprecatedToNewConnectionFactoryFilterafter each user-definedCF to make sure old/new filters work in the same pipeline;
Result:
Information can be propagated from the caller to the
LoadBalancerandConnectionFactory.