Use more specific ConcurrentMap methods
#2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The current use of `ConcurrentMap` methods, especially for `remove()` could be more specific about what it expects to remove or replace and the operation should fail if the expectation is not met. Modifications: Use `ConcurrentMap::remove(key, value)` and `ConcurrentMap::replace(key, oldValue, newValue)` methods Result: Greater assurance of correct behavior as the removed and replaced values are checked.
idelpivnitskiy
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current use of
ConcurrentMapmethods, especially forremove()could be more specific about what it expects to remove or replace and
the operation should fail if the expectation is not met.
Modifications:
Use
ConcurrentMap::remove(key, value)andConcurrentMap::replace(key, oldValue, newValue)methodsResult:
Greater assurance of correct behavior as the removed and replaced
values are checked.