Combine publish-docs.sh and release.sh #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends upon #2195 |
Motivation: publish-docs.sh expects to only run on the main branch. However we also want to generate javadocs on branches other than main, for example to publish updated deprecation notices. Modifications: - Remove publish-docs.sh, and move its logic into release.sh Result: Non-main branches will have javadocs published during release.
Scottmitch
force-pushed
the
release_docs
branch
from
6e359d5 to
99a1af1
Compare
idelpivnitskiy
approved these changes
Apr 20, 2022
Scottmitch
added a commit
that referenced
this pull request
Apr 21, 2022
Motivation: publish-docs.sh expects to only run on the main branch. However we also want to generate javadocs on branches other than main, for example to publish updated deprecation notices. Modifications: - Remove publish-docs.sh, and move its logic into release.sh Result: Non-main branches will have javadocs published during release.
|
0.41 (7f4e633) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
publish-docs.sh expects to only run on the main branch.
However we also want to generate javadocs on branches
other than main, for example to publish updated deprecation
notices.
Modifications:
Result:
Non-main branches will have javadocs published during release.