fix: servicetalk-data-jackson dependency scopes #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The servicetalk-data-jackson-jersey module exposes types that are located in the servicetalk-data-jackson module. Similarly, the servertalk-data-jackson exposes types that are in the servicetalk-serializer-api and servicetalk-serialization-api module. Both of these should be moved to apiscope for each module since they are exported by their apis. Modifications: - make servicetalk-data-jackson and api dependency of servicetalk-data-jackson-jersey - make servicetalk-serializer-api servicetalk-serialization-api and and api dependency of servicetalk-data-jackson Result: Consumers of these modules will get proper transitive dependency behaviors instead of getting class not found issue if they don't manually add the proper dependencies.
bondolo
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
servicetalk-data-jackson-jerseymodule exposes types that arelocated in the
servicetalk-data-jacksonmodule. Similarly, theservicetalk-data-jacksonmodule exposes types that are in theservicetalk-serializer-apiandservicetalk-serialization-apimodules.Dependencies that contain types exposed in a module's API should be imported using
apiscope but currently these dependencies are imported using onlyimplementationscope. Attempting to use the types results in aClassNotFoundException.Modifications:
servicetalk-data-jacksonto anapidependency ofservicetalk-data-jackson-jerseyservicetalk-serializer-apiandservicetalk-serialization-apitoapidependencies ofservicetalk-data-jacksonResult:
Consumers of the
servicetalk-data-jackson-jerseyandservicetalk-data-jacksonmodules will be able to reference all types exposed in these modules' APIs without class not found errors or the need to explicitly importservicetalk-data-jackson,servicetalk-serializer-apiorservicetalk-serialization-apimodules.