Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter dependency for protoc plugin #2209

Merged
merged 3 commits into from
May 11, 2022
Merged

Tighter dependency for protoc plugin #2209

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
809e7f8
Tighter dependency for protoc plugin
bondolo May 10, 2022
2dcb26b
improve comment and reduce testImplementation dependencies.
bondolo May 10, 2022
166cb16
remove dependency on protobuf-java and allow it to be pulled in trans…
bondolo May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions servicetalk-grpc-protoc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,15 @@ dependencies {
// runtimeOnly is enough for this module in isolation, but we want transitive modules to include at compile time too.
api project(":servicetalk-data-protobuf")

implementation "com.google.code.findbugs:jsr305:$jsr305Version"
implementation "com.google.protobuf:protobuf-java:$protobufVersion"
implementation "com.squareup:javapoet:$javaPoetVersion"
compileOnly "com.google.code.findbugs:jsr305:$jsr305Version"
compileOnly "com.google.protobuf:protobuf-java:$protobufVersion"
compileOnly "com.squareup:javapoet:$javaPoetVersion"
idelpivnitskiy marked this conversation as resolved.
Show resolved Hide resolved

testImplementation project(":servicetalk-grpc-api")
testImplementation project(":servicetalk-grpc-protobuf")
testImplementation "com.google.code.findbugs:jsr305:$jsr305Version"
testImplementation "com.google.protobuf:protobuf-java:$protobufVersion"
testImplementation "com.squareup:javapoet:$javaPoetVersion"
testImplementation "org.junit.jupiter:junit-jupiter-api"
testImplementation "org.hamcrest:hamcrest:$hamcrestVersion"
}
Expand All @@ -48,6 +51,8 @@ jar {
}

shadowJar {
// includes javaPoet and Google protobufs
configurations = [project.configurations.compileClasspath]
archiveBaseName = project.name
classifier = 'all'
}
Expand Down