Reduce log level in RoundRobinLoadBalancer #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RoundRobinLoadBalancer logs at the warn level if it takes a host out of rotation due to exceeding the consecutive failure threshold. The failure maybe retried and/or captured in metrics/logs by the application and may not necessarily justify a warn level log from the framework. Modifications: - Adjust log level to debug when below the failure threshold, and info when crossing the threshold. Note the log level is also info when the host is connected to again and taken out of the penalty box.
idelpivnitskiy
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RoundRobinLoadBalancer logs at the warn level if it takes
a host out of rotation due to exceeding the consecutive
failure threshold. The failure maybe retried and/or captured
in metrics/logs by the application and may not necessarily
justify a warn level log from the framework.
Modifications:
and info when crossing the threshold. Note the log level is
also info when the host is connected to again and taken out
of the penalty box.