Use servicetalk-dependencies BOM internally
#2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The new `dependencies` BOM introduced in apple#2210 can be used to improve the management of external dependencies by reducing use of explicit versions within the module `build.gradle` files. Modification: Use `dependencies` BOM for every module which includes `api` or `implementation` external dependencies. The BOM is imported as `api` platform only in cases where the external dependency is also imported `api`. `implementation` platform is used in cases where the external dependencies are only `implementation` dependencies themselves. Result: Fewer explicit version specifications and better managed dependency versioning.
bondolo
commented
May 16, 2022
|
This PR includes only changes for artifact producing configurations, it does not include use of the |
Merged
bondolo
commented
May 17, 2022
bondolo
commented
May 17, 2022
idelpivnitskiy
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The new
dependenciesBOM introduced in #2210 can be used to improvethe management of external dependencies by reducing use of explicit
versions within the module
build.gradlefiles.Modification:
Use
dependenciesBOM for every module which includesapiorimplementationexternal dependencies. The BOM is imported asapiplatform only in cases where the external dependency is also imported
api.implementationplatform is used in cases where the externaldependencies are only
implementationdependencies themselves.Result:
Fewer explicit version specifications and better managed dependency
versioning.