Enhance logging for execution strategy computation #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users should see when the resulting execution strategy is different from what they configured at the builder and should be able to debug the root cause. Modifications: - Log at `info` level when computed strategy adds more offloading to the custom strategy specified at the builder; - Add debug level logging for each computation step when changes are detected; Result: Users see when strategy changes after analyzing filters and are able to debug the cause.
bondolo
reviewed
May 23, 2022
...http-netty/src/main/java/io/servicetalk/http/netty/ClientStrategyInfluencerChainBuilder.java
Outdated
Show resolved
Hide resolved
...http-netty/src/main/java/io/servicetalk/http/netty/ClientStrategyInfluencerChainBuilder.java
Outdated
Show resolved
Hide resolved
bondolo
approved these changes
May 23, 2022
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DefaultHttpServerBuilder.java
Outdated
Show resolved
Hide resolved
…/DefaultHttpServerBuilder.java Co-authored-by: Mike Duigou <bondolo@users.noreply.github.com>
bondolo
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users should see when the resulting execution strategy is different from
what they configured at the builder and should be able to debug the
root cause.
Modifications:
infolevel when computed strategy adds more offloading to thecustom strategy specified at the builder;
detected;
Result:
Users see when strategy changes after analyzing filters and are able to
debug the cause.