HttpLifecycleObserver: notify when payload body is requested
#2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Track how subscriber requests payload body items. Modifications: - Add `HttpRequestObserver#onRequestDataRequested(long)`; - Add `HttpResponseObserver#onResponseDataRequested(long)`; - Enhance `HttpLifecycleObserverTest` and `GrpcLifecycleObserverTest`; Result: Users can track how many items subscriber requests from payload body, and time difference between requested-delivered items.
tkountis
approved these changes
Jun 3, 2022
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jun 8, 2022
Motivation: When we added two new callbacks in apple#2230, we forgot to add a default impl for one of them. Modifications: - Add default noop impl for `HttpResponseObserver#onResponseDataRequested(long)`; Result: `HttpResponseObserver` is backward compatible for existing users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Track how subscriber requests payload body items.
Modifications:
HttpRequestObserver#onRequestDataRequested(long);HttpResponseObserver#onResponseDataRequested(long);HttpLifecycleObserverTestandGrpcLifecycleObserverTest;Result:
Users can track how many items subscriber requests from payload body,
and time difference between requested-delivered items.