Update Netty 4.1.77 -> 4.1.78 #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
approved these changes
Jun 15, 2022
bondolo
approved these changes
Jun 15, 2022
| // We manage flushes at ST level and don't want netty to flush the preface & settings only. Instead, we write | ||
| // headers or entire message and flush them all together. Netty changed the default flush behavior starting from | ||
| // 4.1.78.Final. For context, see https://github.com/netty/netty/pull/12349. | ||
| flushPreface(false); |
There was a problem hiding this comment.
For users which run older Netty with ServiceTalk I assume that this change will have no impact since the prior default was to not flush the preface, correct?
There was a problem hiding this comment.
Correct. You have a good point about older versions of netty. I've switched to MethodHandle to avoid breaking users who may depend on older netty.
Scottmitch
reviewed
Jun 15, 2022
| MethodHandle flushPreface; | ||
| try { | ||
| // Find a new method that exists only in Netty starting from 4.1.78.Final: | ||
| flushPreface = MethodHandles.publicLookup() |
There was a problem hiding this comment.
should we create an issue to eventually just use the API directly?
bondolo
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.