BufferDecoderGroupBuilder#add method w/out advertised #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: BufferDecoderGroupBuilder#add has an `advertised` parameter which often is true and the impacts of it being false may not be clear. Modifications: - Add BufferDecoderGroupBuilder#add with no `advertised` param - Clarify javadoc on BufferDecoderGroupBuilder#add method for `advertised == false` implications.
tkountis
approved these changes
Jun 17, 2022
|
build failure attributed to #2245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
BufferDecoderGroupBuilder#add has an
advertisedparameterwhich often is true and the impacts of it being false may not
be clear.
Modifications:
advertisedparamadvertised == falseimplications.