Enhance exception message thrown from appendNonOffloadingServiceFilter
#2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Currently, `appendNonOffloadingServiceFilter` does not include a name of the filter/predicate that triggers this exception. It makes it harder to understand the root cause. Modifications: - Reword the `IllegalArgumentException` message to include the class name of the filter/predicate, and suggestion for resolution; Result: Easier for users to understand the root cause and how to fix it.
bondolo
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently,
appendNonOffloadingServiceFilterdoes not include a name ofthe filter/predicate that triggers this exception. It makes it harder to
understand the root cause.
Modifications:
IllegalArgumentExceptionmessage to include the classname of the filter/predicate, and suggestion for resolution;
Result:
Easier for users to understand the root cause and how to fix it.