Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netty-incubator-transport-native-io_uring to servicetalk-dependencies #2295

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Add netty-incubator-transport-native-io_uring to servicetalk-dependencies #2295

merged 3 commits into from
Jul 29, 2022
+15 −7

Conversation

Scottmitch
Copy link
Member

@Scottmitch Scottmitch commented Jul 28, 2022 •
edited
Loading

Motivation:
netty-incubator-transport-native-io_uring is referenced in multiple projects
and not yet included in Netty's bom. We should include it in the dependency
bom to align versions until Netty provides this.

@Scottmitch Scottmitch changed the title Add netty-incubator-transport-native-io_uring to servicetalk-dependen… Add netty-incubator-transport-native-io_uring to servicetalk-dependencies Jul 28, 2022
bondolo
bondolo approved these changes Jul 28, 2022
View reviewed changes
servicetalk-dependencies/build.gradle Outdated Show resolved Hide resolved
servicetalk-dependencies/build.gradle Outdated Show resolved Hide resolved
@idelpivnitskiy
Copy link
Member

The idea lgtm, build fails with:

/home/runner/work/servicetalk/servicetalk/servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/BuilderUtils.java:102: error: cannot find symbol
            return IOUringSocketChannel.class;
                   ^
  symbol:   class IOUringSocketChannel
  location: class BuilderUtils

@Scottmitch
Add netty-incubator-transport-native-io_uring to servicetalk-dependen…
031e43a 
…cies

Motivation:
netty-incubator-transport-native-io_uring is referenced in multiple projects
and not yet included in Netty's bom. We should include it in the dependency
bom to align versions until Netty provides this.
@Scottmitch
fix build
8d9db48
@Scottmitch Scottmitch marked this pull request as ready for review July 29, 2022 05:05
@Scottmitch
Copy link
Member Author

build failure attributed to #2298

@Scottmitch Scottmitch merged commit bd7b9da into apple:main Jul 29, 2022
@Scottmitch Scottmitch deleted the io_uring_bom branch July 29, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondolo bondolo bondolo approved these changes

@idelpivnitskiy idelpivnitskiy Awaiting requested review from idelpivnitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scottmitch @idelpivnitskiy @bondolo