Remove unused internal code from servicetalk-grpc-api
#2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#1893 removed gRPC filter functionality, but left some internal code required to support removed filters. Modifications: - Remove `GrpcRoutes#drainToStreamingRoutes()`; - Remove `GrpcRouteConversions`, remove conversions from `RouteProvider`; - Make `RouteProvider` class private; - Remove unused `GrpcUtils#newResponse` overload; Result: No unused code.
Scottmitch
approved these changes
Jul 29, 2022
servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcRouter.java
Outdated
Show resolved
Hide resolved
| @@ -952,5 +849,31 @@ public Completable closeAsync() { | |||
| public Completable closeAsyncGracefully() { | |||
| return closeable.closeAsyncGracefully(); | |||
| } | |||
|
|
|||
| private static AsyncCloseable toAsyncCloseable(final GracefulAutoCloseable original) { | |||
There was a problem hiding this comment.
did you consider putting this someone more visible (AutoClosableUtils, AsyncCloseables, ..)?
There was a problem hiding this comment.
I will do it in a separate PR for visibility and will use the same utility in HTTP conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#1893 removed gRPC filter functionality, but left some internal code
required to support removed filters.
Modifications:
GrpcRoutes#drainToStreamingRoutes();GrpcRouteConversions, remove conversions fromRouteProvider;RouteProviderclass private;GrpcUtils#newResponseoverload;Result:
No unused code.