Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share bom inclusion closure to reduce code duplication #2307

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Share bom inclusion closure to reduce code duplication #2307

merged 2 commits into from
Aug 4, 2022

Conversation

Scottmitch
Copy link
Member

No description provided.

@Scottmitch Scottmitch marked this pull request as ready for review August 4, 2022 17:49
bondolo
bondolo approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@bondolo bondolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to see if there was a way to reference the bomInclusionClosure as a method reference but could not get the groovy syntax right.

@Scottmitch Scottmitch merged commit ccf01ca into apple:main Aug 4, 2022
@Scottmitch Scottmitch deleted the bom_share branch August 4, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondolo bondolo bondolo approved these changes

@tkountis tkountis Awaiting requested review from tkountis

@idelpivnitskiy idelpivnitskiy Awaiting requested review from idelpivnitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scottmitch @bondolo