Calculate initial concurrency based on resulting connection protocol #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `RequestConcurrencyController` is always applied as the top level wrapper of the connection (after all connection-level filters) before returning it back to the `LoadBalancer`. As the result, there is no need to make an earlier decision for `initialConcurrency` value at `AbstractLBHttpConnectionFactory` implementation (when the final protocol may be unknown) because it can be inferred based on the resulting connection protocol at the time a new `ReservableRequestConcurrencyController` is created. Early initialization as it's now makes it harder to switch protocols after proxy connect. Modifications: - Remove abstract method `AbstractLBHttpConnectionFactory.newConcurrencyController`; - Compute `initialConcurrency` based on connection's protocol and `ReadOnlyHttpClientConfig`; - Update `ReservableRequestConcurrencyControllersTest`; Result: No need to pre-initialize `initialConcurrency` value in `AbstractLBHttpConnectionFactory` implementations as it will be computed based on the connection's protocol at the time it's required.
|
I'm trying to extract meaningful code changes into independent PRs before finalizing PR for a proxy connect with ALPN (can switch from HTTP/1.1 to HTTP/2 protocol) |
daschl
approved these changes
Sep 14, 2023
…mputation logic to `AbstractLBHttpConnectionFactory`
|
@daschl as we discussed offline, reverted changes for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RequestConcurrencyControlleris always applied as the top level wrapper of the connection (after all connection-level filters) before returning it back to theLoadBalancer. As the result, there is no need to make an earlier decision forinitialConcurrencyvalue at implementations ofAbstractLBHttpConnectionFactory(when the final protocol may be unknown) because it can be inferred based on the resulting connection protocol at the time a newReservableRequestConcurrencyControlleris created. Early initialization as it's now makes it harder to switch protocols after proxy connect.Modifications:
AbstractLBHttpConnectionFactory.newConcurrencyControllerinto a private method;initialConcurrencybased on connection's protocol andReadOnlyHttpClientConfig;Result:
No need to pre-initialize
initialConcurrencyvalue inAbstractLBHttpConnectionFactoryimplementations as it will be computed based on the connection's protocol at the time it's required.