ProtobufSerializer minimize getSerializedSize() usage #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ProtobufSerializer uses `MessageLite.getSerializedSize()` on each serialization operation. This method may require a deep traversal of all internal objects and require intermediate allocations (e.g. for maps) to compute the actual size. Modifications: - Use `CodedOutputStream.getTotalBytesWritten()` and `CodedInputStream.getTotalBytesRead()` to determine how many bytes were generated/consumed during serialization.
Scottmitch
requested review from
chrisvest,
mgodave,
bryce-anderson,
tkountis and
idelpivnitskiy
bryce-anderson
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ProtobufSerializer uses
MessageLite.getSerializedSize()on each serialization operation. This method may require a deep traversal of all internal objects and require intermediate allocations (e.g. for maps) to compute the actual size.Modifications:
CodedOutputStream.getTotalBytesWritten()andCodedInputStream.getTotalBytesRead()to determine how many bytes were generated/consumed during serialization.