Introduce defaultHttp(s)Port for MultiAddressHttpClientBuilder #2703
+118
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
force-pushed
the
default-port
branch
from
46634ae to
a8bc684
Compare
idelpivnitskiy
requested changes
Sep 22, 2023
servicetalk-http-api/src/main/java/io/servicetalk/http/api/MultiAddressHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/DefaultMultiAddressUrlHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
...cetalk-http-netty/src/test/java/io/servicetalk/http/netty/MultiAddressUrlHttpClientTest.java
Outdated
Show resolved
Hide resolved
Motivation ---------- At the moment, if no port number is explicitly provided, the default HTTP and HTTPS ports are used (80 and 443). In some environments it can be useful (i.e. if a client is always talking to a high port number) to not have to specify it on every request. Modifications ------------- This changeset introduces two new builder options to allow customizing the defaultHttpPort as well as the defaultHttpsPort and applying it if no explicit port is provided on the request itself. Result ------ It is now possible to not specify the port number on every request if they diverge from the default 80 or 443 port numbers.
daschl
force-pushed
the
default-port
branch
from
a8bc684 to
b765db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment, if no port number is explicitly provided, the default HTTP and HTTPS ports are used (80 and 443). In some environments it can be useful (i.e. if a client is always talking to a high port number) to not have to specify it on every request.
Modifications
This changeset introduces two new builder options to allow customizing the defaultHttpPort as well as the defaultHttpsPort and applying it if no explicit port is provided on the request itself.
Result
It is now possible to not specify the port number on every request if they diverge from the default 80 or 443 port numbers.