Support proxy for plaintext HTTP/2 clients with prior-knowledge #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Plaintext proxies operate as forwarding message proxies. They expect clients to send requests with absolute-form request-target to determine where to forward the message. This logic does not depend on the protocol version, it already works for HTTP/1.1 and should work for HTTP/2 the same way. Modifications: - `DefaultSingleAddressHttpClientBuilder`: remove check that does not allow users to use HTTP/2 prior-knowledge with a proxy over plaintext connections; - Enhance `HttpProxyTest` to validate behavior consistency for both protocols; Result: Users can use plaintext HTTP/2 prior-knowledge clients to communicate via a forwarding message proxy.
Scottmitch
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Plaintext proxies operate as forwarding message proxies. They expect clients to send requests with absolute-form request-target to determine where to forward the message. This logic does not depend on the protocol version, it already works for HTTP/1.1 and should work for HTTP/2 the same way.
Modifications:
DefaultSingleAddressHttpClientBuilder: remove check that does not allow users to use HTTP/2 prior-knowledge with a proxy over plaintext connections;HttpProxyTestto validate behavior consistency for both protocols;Result:
Users can use plaintext HTTP/2 prior-knowledge clients to communicate via a forwarding message proxy.