Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-netty: Fix flaky SslAndNonSslConnectionsTest #2755

Merged
merged 10 commits into from
Nov 14, 2023
Merged

http-netty: Fix flaky SslAndNonSslConnectionsTest #2755

merged 10 commits into from
Nov 14, 2023

Conversation

bryce-anderson
Copy link
Contributor

@bryce-anderson bryce-anderson commented Nov 13, 2023 •
edited
Loading

Motivation

We have a flaky test. It appears to be a rare case of netty
sending an IOException down the exceptionCaught netty
pipeline pathway that isn't handled.

Modifications

  • Widen what we expect in the test to IOException

Closes #2403

@bryce-anderson
Copy link
Contributor Author

@idelpivnitskiy, I don't necessarily like the fix for this so your expertise/feedback would be appreciated. Is there a better place to convert these exceptions? This feels like it's really a netty channelClosed(Throwable) event that is being sent down the wrong tube, but that isn't something we can fix here.

@bryce-anderson bryce-anderson changed the title See if this consistently surfaces the flake http-netty: concert NativeIoException instances into ClosedChannelException Nov 14, 2023
@bryce-anderson bryce-anderson changed the title http-netty: concert NativeIoException instances into ClosedChannelException http-netty: convert some IOException instances into ClosedChannelException Nov 14, 2023
@bryce-anderson bryce-anderson marked this pull request as ready for review November 14, 2023 00:47
idelpivnitskiy
idelpivnitskiy reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

...y-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java Outdated Show resolved Hide resolved
@bryce-anderson bryce-anderson changed the title http-netty: convert some IOException instances into ClosedChannelException http-netty: Fix flaky SslAndNonSslConnectionsTest Nov 14, 2023
@bryce-anderson bryce-anderson merged commit 370a81a into apple:main Nov 14, 2023
13 checks passed
@bryce-anderson bryce-anderson deleted the bl_anderson/SslAndNonSslConnectionsTest_flaky branch November 14, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idelpivnitskiy idelpivnitskiy idelpivnitskiy approved these changes

@Scottmitch Scottmitch Awaiting requested review from Scottmitch

@tkountis tkountis Awaiting requested review from tkountis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SslAndNonSslConnectionsTest
2 participants
@bryce-anderson @idelpivnitskiy