loadbalancer: fix NormalizedTimeSourceExecutor to work with units other than nanos #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than nanos Motivation: The time source normalizes itself using nanoseconds regardless of what units the user is requesting. Modifications: - Always get the current time in nanos, normalize, then convert to the desired units. Result: Better behavior.
bryce-anderson
requested review from
idelpivnitskiy,
daschl,
mgodave and
tkountis
mgodave
approved these changes
Dec 21, 2023
bryce-anderson
deleted the
bl_anderson/fix_NormalizedTimeSourceExecutor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The time source normalizes itself using nanoseconds regardless
of what units the user is requesting.
Modifications:
the desired units.
Result:
Better behavior if you request anything other than nanos.