examples: add an example of using DefaultLoadBalancer #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We want an example to show how to test drive DefaultLoadBalancer. Modifications: - Add an example.
idelpivnitskiy
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
All examples should be referenced from docs website, see this PR as an example: https://github.com/apple/servicetalk/pull/2147/files#diff-2ea47e69b86a450929c960c09588f5debf6381cff7baf27db90988d086053a49
You need to modify:
- servicetalk-examples/docs/modules/ROOT/pages/_partials/nav-versioned.adoc
- servicetalk-examples/docs[modules/ROOT/pages/grpc/index.adoc
Other than that, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want an example to show how to test drive DefaultLoadBalancer.
Modifications: