loadbalancer-experimental: Rename HealthChecker to OutlierDetector #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: HealthChecker has a very different meaning in most existing contexts which is an abstraction that will verify if a host is healthy (or not). We use it to define the entire system of detecting bad hosts which may cause confusion. Modifications: - Align with the more common industry terminology. - Add type parameters to things that may need to know the concrete type of the connection (C) in the future for true health checking.
idelpivnitskiy
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HealthChecker has a very different meaning in most existing contexts which is an abstraction that will verify if a host is healthy (or not). We use it to define the entire system of detecting bad hosts which may cause confusion.
Modifications: