loadbalancer-experimental: tighten up load balancing policy #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The LoadBalancingPolicy interface suffers from the same problems that the OutlierDetectorFactory did, namely that it's more powerful than users need. Modifications: - Make the LoadBalancingPolicy an abstract class with package private constructor to let us control its proliferation for now. Result: A more constrained API. We can always open it up more later if we want to.
bryce-anderson
requested review from
daschl,
mgodave,
tkountis and
idelpivnitskiy
|
This is an alternative to #2883. |
idelpivnitskiy
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The LoadBalancingPolicy interface suffers from the same problems that the OutlierDetectorFactory did, namely that it's more powerful than users need.
Modifications:
Result:
A more constrained API. We can always open it up more later if we want to.