loadbalancer-experimental: add provider for enabling DefaultLoadBalancer #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncer Motivation: We want to make it easy for people to enable the DefaultLoadBalancer. Modifications: - add a new package that includes a provider that can be used
bryce-anderson
requested review from
daschl,
mgodave,
tkountis and
idelpivnitskiy
daschl
reviewed
Apr 25, 2024
.../src/main/java/io/servicetalk/loadbalancer/experimental/DefaultHttpLoadBalancerProvider.java
Show resolved
Hide resolved
.../src/main/java/io/servicetalk/loadbalancer/experimental/DefaultHttpLoadBalancerProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerProviderConfig.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerProviderConfig.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerProviderConfig.java
Outdated
Show resolved
Hide resolved
bryce-anderson
force-pushed
the
bl_anderson/experimental-lb-provider
branch
from
4fb8b35 to
3e52a30
Compare
daschl
reviewed
Apr 26, 2024
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Outdated
Show resolved
Hide resolved
...ider/src/main/java/io/servicetalk/loadbalancer/experimental/DefaultLoadBalancerObserver.java
Show resolved
Hide resolved
daschl
approved these changes
Apr 26, 2024
| testImplementation enforcedPlatform("org.junit:junit-bom:$junit5Version") | ||
|
|
||
| api project(":servicetalk-client-api") | ||
| api project(":servicetalk-concurrent-api") |
There was a problem hiding this comment.
The only api dependency should be :servicetalk-http-api. Others are transitive dependencies through http-api. If you'd like, you can keep an explicit definition of :servicetalk-client-api as well, but there is no dependency on :servicetalk-concurrent-api.
| HttpLoadBalancerFactory<R> loadBalancerFactory = DefaultHttpLoadBalancerFactory.Builder.<R>from( | ||
| defaultLoadBalancer(serviceName)).build(); | ||
| builder = builder.loadBalancerFactory(loadBalancerFactory); | ||
| return new LoadBalancerIgnoringBuilder(builder, serviceName); |
There was a problem hiding this comment.
Missing <> after class name
| private final String clientName; | ||
|
|
||
| DefaultLoadBalancerObserver(final String clientName) { | ||
| this.clientName = requireNonNull(clientName, "clientName"); |
There was a problem hiding this comment.
Would be ideal if the DefaultLoadBalancer could propagate its lbDescription. The main motivation is being able to distinguish one instance of a client to "servicetalk.io" (or any "serviceFoo") from another instance to exact same address. Additionally, it will help to correlate observer events with DefaultLoadBalancer logs.
| } | ||
|
|
||
| <U, C extends LoadBalancedConnection> LoadBalancingPolicy<U, C> getLoadBalancingPolicy() { | ||
| if (lbPolicy == lbPolicy.P2C) { |
There was a problem hiding this comment.
nit: lbPolicy.P2C -> LbPolicy.P2C
| } | ||
| } | ||
|
|
||
| private Set<String> getClientsEnabledFor(String propertyValue) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to make it easy for users to enable DefaultLoadBalancer
for specific clients and then manipulate it's behavior via system
properties so they don't require rebuilding apps to test.
Modifications:
Add a new package that includes a
SingleAddressHttpClientBuilderProviderwhich enables users to enable DefaultLoadBalancer for clients
based on the address used, or all clients if desired.