-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce traffic resiliency features #2911
Conversation
46eb23c
to
8b1e23c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than I'm curious if we can remove the deprecated API's.
...ter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/GradientCapacityLimiter.java
Show resolved
Hide resolved
...er-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/CompositeCapacityLimiter.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/io/servicetalk/apple/capacity/limiter/api/FixedCapacityLimiterBuilder.java
Outdated
Show resolved
Hide resolved
...ter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/GradientCapacityLimiter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/servicetalk/apple/capacity/limiter/api/GradientCapacityLimiterBuilder.java
Outdated
Show resolved
Hide resolved
...acity-limiter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/Preconditions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 after fixing the weight()
doc string. I'd personally prefer to change the method name to priority()
since it aligns well with the documentation of it but I'm not strongly opinionated about it.
...city-limiter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/Classification.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a patch in my last comment that addresses some other findings. Consider applying it first before working on other comments:
servicetalk-utils-internal/src/main/java/io/servicetalk/utils/internal/NumberUtils.java
Show resolved
Hide resolved
...limiter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/AimdCapacityLimiter.java
Show resolved
Hide resolved
...ity-limiter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/CapacityLimiter.java
Show resolved
Hide resolved
...ter-api/src/main/java/io/servicetalk/apple/capacity/limiter/api/AllowAllCapacityLimiter.java
Show resolved
Hide resolved
...in/java/io/servicetalk/apple/traffic/resilience/http/TrafficResilienceHttpServiceFilter.java
Show resolved
Hide resolved
...in/java/io/servicetalk/apple/traffic/resilience/http/TrafficResilienceHttpServiceFilter.java
Show resolved
Hide resolved
...in/java/io/servicetalk/apple/traffic/resilience/http/TrafficResilienceHttpServiceFilter.java
Show resolved
Hide resolved
.../src/main/java/io/servicetalk/apple/traffic/resilience/http/PeerCapacityRejectionPolicy.java
Show resolved
Hide resolved
Motivation: Minor comments for apple#2911.
Motivation: Minor comments for apple#2911.
Motivation: Minor comments for #2911.
Motivation
Lack of common resiliency features like breakers, limiters and integrations with the remaining of the client workflows.
Modifications
Support for