Reduce default TLS handshake timeout from 10 to 5 seconds #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 10 seconds feels like too high value to hold a connection attempt by waiting for TLS handshake to complete. Because TLS handshake happens before ST writes a request, it's always marked as `RetryableException` and is retried up to 3 times. Modifications: - Reduce `DEFAULT_HANDSHAKE_TIMEOUT` from 10 to 5 seconds; Result: Less wait time for TLS handshake process that hangs longer than expected.
tkountis
approved these changes
May 29, 2024
bryce-anderson
approved these changes
May 30, 2024
daschl
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
10 seconds feels like too high value to hold a connection attempt by waiting for TLS handshake to complete. Because TLS handshake happens before ST writes a request, it's always marked as
RetryableExceptionand is retried up to 3 times.Modifications:
DEFAULT_HANDSHAKE_TIMEOUTfrom 10 to 5 seconds;Result:
Less wait time for TLS handshake process that hangs longer than expected.