loadbalancer-experimental: DefaultLoadBalancer logs settings on startup #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As DefaultLoadBalancer becomes the norm it can be helpful to track its activation via log messages. Modifications: - Emit a log message on startup that includes the lb description and important settings. - Fix a bug where the cancellation penalty was inadvertently used for the error penalty. - Cancel the update stream from the OutlierDetector when the lb closes.
bryce-anderson
commented
Jul 9, 2024
Comment on lines
+172
to
173
| this.outlierDetectorStatusChangeStream = this.outlierDetector.healthStatusChanged().forEach((ignored) -> | ||
| sequentialExecutor.execute(() -> sequentialUpdateUsedHosts(usedHosts))); |
There was a problem hiding this comment.
Previously this was simply discarded which was fine because of the way it's implemented but we might as well cancel it in case that changes in the future.
There was a problem hiding this comment.
Good catch. Up to you if you'd like to keep it here or move into a separate PR for visibility.
idelpivnitskiy
approved these changes
Jul 9, 2024
Comment on lines
+172
to
173
| this.outlierDetectorStatusChangeStream = this.outlierDetector.healthStatusChanged().forEach((ignored) -> | ||
| sequentialExecutor.execute(() -> sequentialUpdateUsedHosts(usedHosts))); |
There was a problem hiding this comment.
Good catch. Up to you if you'd like to keep it here or move into a separate PR for visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As DefaultLoadBalancer becomes the norm it can be helpful to track its activation via log messages.
Modifications: