capacity-limiter-api: polish javadocs and minor code modifications #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschl
requested review from
idelpivnitskiy,
bryce-anderson and
tkountis
and removed request for
idelpivnitskiy
tkountis
approved these changes
Aug 5, 2024
bryce-anderson
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
These seem fine to me.
Feel free to ignore: while you're here would you like to change the documentation for the meaning of the return values, specifically that the hints have meaning if they're non-negative? The only place I see it used in non-tests is here where only negative values are ignored (eg, 0 has meaning).
Will do this as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset mainly polishes javadocs as well as cleans up the implementations slightly without changing their behavior.