http-netty: fix JavaNetSoTimeoutHttpConnectionFilter leak #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-anderson
force-pushed
the
bl_anderson/JavaNetSoTimeoutHttpConnectionLeakFix
branch
from
8ccfdff to
38adcda
Compare
bryce-anderson
force-pushed
the
bl_anderson/JavaNetSoTimeoutHttpConnectionLeakFix
branch
from
38adcda to
882cec8
Compare
bryce-anderson
changed the title
idelpivnitskiy
requested changes
Aug 17, 2024
...-netty/src/test/java/io/servicetalk/http/netty/JavaNetSoTimeoutHttpConnectionFilterTest.java
Outdated
Show resolved
Hide resolved
...-netty/src/test/java/io/servicetalk/http/netty/JavaNetSoTimeoutHttpConnectionFilterTest.java
Outdated
Show resolved
Hide resolved
...-netty/src/test/java/io/servicetalk/http/netty/JavaNetSoTimeoutHttpConnectionFilterTest.java
Outdated
Show resolved
Hide resolved
...-netty/src/test/java/io/servicetalk/http/netty/JavaNetSoTimeoutHttpConnectionFilterTest.java
Outdated
Show resolved
Hide resolved
...-netty/src/test/java/io/servicetalk/http/netty/JavaNetSoTimeoutHttpConnectionFilterTest.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
...http-utils/src/main/java/io/servicetalk/http/utils/JavaNetSoTimeoutHttpConnectionFilter.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Aug 21, 2024
bryce-anderson
deleted the
bl_anderson/JavaNetSoTimeoutHttpConnectionLeakFix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There is a resource leak in the JavaNetSoTimeoutHttpConnectionFilter
rooted in the use of the
ambWith(..)operator: if the response channelloses the race with the timer the resulting response will be dropped on
the floor along with it's hot
payloadBody().Modifications:
Replace the
ambWithwith a custom operator that gives us the abilityto cleanup a losing response while also giving us the correct latching
behavior between cancellation, timeout, and response pathways.