Single.repeat: use TerminateRepeatException as a terminal marker
#3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Currently, `RepeatWhenSingle` uses its own static `END_REPEAT_EXCEPTION` object as an end marker. That static exception does not discard suppressed exceptions. If under any circumcises it unintentionally leaks, it may cause a memory leak if some path adds suppressed exceptions to it. Also, it's inconsistent with `RepeatStrategies`. Modifications: - Use `RepeatStrategies.TerminateRepeatException` instead that discards suppressed exceptions and doesn't write stacktrace. - Cache failed `Completable` with `TerminateRepeatException` instance instead of allocating a new one on every repeat check. Result: 1. Avoids static exception instance that may attach suppressed exceptions. 2. Consistency between all repeat operators and strategies.
daschl
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently,
RepeatWhenSingleuses its own staticEND_REPEAT_EXCEPTIONobject as an end marker. That static exception does not discard suppressed exceptions. If under any circumcises it unintentionally leaks, it may cause a memory leak if some path adds suppressed exceptions to it. Also, it's inconsistent withRepeatStrategies.Modifications:
RepeatStrategies.TerminateRepeatExceptioninstead that discards suppressed exceptions and doesn't write stacktrace.CompletablewithTerminateRepeatExceptioninstance instead of allocating a new one on every repeat check.Result: