ConnectablePayloadWriter: avoid static exception that may leak memory
#3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `ConnectablePayloadWriter` uses a static `IOException` instance as a state and can propagate it to `Subscriber`. This opens a possibility for a memory leak if `Subscriber` or intermediate operators attach a suppressed exception to this static instance. Modifications: - Create `StacklessCancelledIOException` and always use a new instance in case of cancellation; - Keep `cancel()` noop if `outer.closed != null`; Result: `ConnectablePayloadWriter` can not leak memory via static exception instance.
daschl
reviewed
Aug 21, 2024
...-internal/src/main/java/io/servicetalk/concurrent/api/internal/ConnectablePayloadWriter.java
Show resolved
Hide resolved
bryce-anderson
approved these changes
Aug 21, 2024
daschl
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ConnectablePayloadWriteruses a staticIOExceptioninstance as a state and can propagate it toSubscriber. This opens a possibility for a memory leak ifSubscriberor intermediate operators attach a suppressed exception to this static instance.Modifications:
StacklessCancelledIOExceptionand always use a new instance in case of cancellation;cancel()noop ifouter.closed != null;Result:
ConnectablePayloadWritercan not leak memory via static exception instance.