Stop using servicetalk-dependencies internally
#3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Gradle interprets `*.module` files differently than the `pom.xml`. Because every module currently depends on `servicetalk-dependencies`, users pulled its `dependencyConstraints` in their build configurations with any servicetalk module as transitive dependency and got unintended changes for other dependencies. For example, `servicetalk-annotations` that has only jsr305 as a 3-party dependency still forces upgrade of jackson, protobuf, log4j, netty, and jersey for users because it depends on `servicetalk-dependencies`. Modifications: - Remove `servicetalk-dependencies` from every module, instead define every necessary dependency by its version number or import only required boms; - Update `servicetalk-dependencies` to include missed dependencies: opentelemetry, instrumentation, resilience4j; - Correct dependencies for all `-jersery3` modules to keep only what they use; - Move all `platform` dependencies from the top to their corresponding scope; - Regenerate lock files; Result: Users don't get unintended dependency upgrades because of the `*.module` file handling.
daschl
reviewed
Sep 9, 2024
daschl
approved these changes
Sep 9, 2024
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Oct 15, 2024
Motivation: Maven helped to identify that after apple#3055 generated pom.xml files are invalid. We forgot to include `netty-bom` in some modules that depend on `io.netty` without specifying netty version. Also, noticed that some of our modules that use `io.netty` do not list all used netty dependencies as needed. Modifications: - For all modules that contain `-netty` in their names add missed `netty-bom` and some other netty dependencies that are used explicitly; - `servicetalk-buffer-netty`: add missed `netty-common` dependency; - `servicetalk-transport-netty`: remove unused `netty-common` dependency; Result: Gradle generates valid pom.xml files.
idelpivnitskiy
added a commit
that referenced
this pull request
Oct 15, 2024
Motivation: Maven helped to identify that after #3055 generated pom.xml files are invalid. We forgot to include `netty-bom` in some modules that depend on `io.netty` without specifying netty version. Also, noticed that some of our modules that use `io.netty` do not list all used netty dependencies as needed. Modifications: - For all modules that contain `-netty` in their names add missed `netty-bom` and some other netty dependencies that are used explicitly; - `servicetalk-buffer-netty`: add missed `netty-common` dependency; - `servicetalk-transport-netty`: remove unused `netty-common` dependency; Result: Gradle generates valid pom.xml files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Gradle interprets
*.modulefiles differently than thepom.xml. Because every module currently depends onservicetalk-dependencies, users pulled itsdependencyConstraintsin their build configurations with any servicetalk module as transitive dependency and got unintended changes for other dependencies.For example,
servicetalk-annotationsthat has only jsr305 as a 3-party dependency still forces upgrade of jackson, protobuf, log4j, netty, and jersey for users because it depends onservicetalk-dependencies.Modifications:
servicetalk-dependenciesfrom every module, instead define every necessary dependency by its version number or import only required boms;servicetalk-dependenciesto include missed dependencies: opentelemetry, instrumentation, resilience4j;-jersery3modules to keep only what they use;platformdependencies from the top to their corresponding scope;Result:
Users don't get unintended dependency upgrades because of the
*.modulefile handling.