Allow null value for query parameter setter methods #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpQuery.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpQuery.java
Show resolved
Hide resolved
Scottmitch
force-pushed
the
query_null
branch
2 times, most recently
from
f5ab519 to
b404a16
Compare
Motivation: 041f3dc replace empty string for null during parsing. However the setter/accessor methods don't consistently allow null values. Modifications: - Allow null values from add & set queryParameter methods.
Scottmitch
force-pushed
the
query_null
branch
from
b404a16 to
1bb1ca3
Compare
bryce-anderson
approved these changes
Sep 19, 2024
daschl
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
041f3dc replace empty string for null during parsing. However the setter/accessor methods don't consistently allow null values.
Modifications: