loadbalancer-experimental: make DefaultLoadBalancer the default RR implementation #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation Motivation: It's been out a while now and DefaultLoadBalancer can exactly behave as the old RoundRobinLoadBalancer. That means we can insert it in place of RoundRobinLoadBalancer. Modifications: Default to building a DefaultLoadBalancer in round-robin compatibility mode via the RoundRobinToDefaultLBMigrationProvider. We retain the flag for safety for a few releases but will eventually remove it and RoundRobinLoadBalancer. Result: What is the result of this change?
bryce-anderson
changed the title
idelpivnitskiy
approved these changes
Sep 25, 2024
|
Failures are known flaky tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's been out a while now and DefaultLoadBalancer can exactly behave as the old RoundRobinLoadBalancer. That means we can insert it in place of RoundRobinLoadBalancer.
Modifications:
Default to building a DefaultLoadBalancer in round-robin compatibility mode via the RoundRobinToDefaultLBMigrationProvider. We retain the flag for safety for a few releases but will eventually remove it and RoundRobinLoadBalancer.