Preserve default Http2Settings when Http2SettingsBuilder is used
#3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: By default we set values for `MAX_HEADER_LIST_SIZE` and `INITIAL_WINDOW_SIZE` settings at `H2ProtocolConfigBuilder` level. However, if users want to change only one setting (for example, `MAX_CONCURRENT_STREAMS`), they loos our defaults when they use `Http2SettingsBuilder`. Modifications: - Move defaults initialization from `H2ProtocolConfigBuilder` to `Http2SettingsBuilder`. Result: Users always start with consistent default `Http2Settings` and can use builder methods to override what they want.
daschl
approved these changes
Nov 8, 2024
mgodave
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
By default we set values for
MAX_HEADER_LIST_SIZEandINITIAL_WINDOW_SIZEsettings atH2ProtocolConfigBuilderlevel. However, if users want to change only one setting (for example,MAX_CONCURRENT_STREAMS), they lose our defaults when they useHttp2SettingsBuilder.Modifications:
H2ProtocolConfigBuildertoHttp2SettingsBuilder.Result:
Users always start with consistent default
Http2Settingsand can use builder methods to override what they want.