loadbalancer: remove RoundRobinLoadBalancerBuilderProvider and inline its behavior #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-anderson
force-pushed
the
bl_anderson/DefaultLBMigrationProvider
branch
from
5cfa2e9 to
2454018
Compare
Motivation: Now that DefaultLoadBalancer is in the main loadbalancer package we can avoid using a provider to facilitate the migration. Modifications: Remove the migration provider and instead use the types directly.
bryce-anderson
force-pushed
the
bl_anderson/DefaultLBMigrationProvider
branch
from
2454018 to
96f9329
Compare
bryce-anderson
changed the title
idelpivnitskiy
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that DefaultLoadBalancer is in the servicetalk-loadbalancer
module we no longer need to use a provider in order to migrate
RoundRobinLoadBalancer users to DefaultLoadBalancer.
Modifications:
RoundRobinLoadBalancer in RoundRobinLoadBalancerBuilder.