Fix flakiness in ResponseCancelTest
#954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Motivation__ `ResponseCancelTest` is flaky due to a race condition that successful response or cancel will race to get to the connection filter and the result will either be success or failure. __Modification__ - `cancel()` and `cancelAfterSuccessOnTransport()` tests were both doing same actions unintentionally. Modified the test to reflect the intentions. - `cancelAfterSuccessOnTransport()` can either result in success or failure after the first request, modified test to verify the same. __Result__ Fix tests.
|
Looks like CI is happy. I will pull this in and update other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ResponseCancelTestis flaky due to a race condition that successful response or cancel will race to get to the connection filter and the result will either be success or failure.Modification
cancel()andcancelAfterSuccessOnTransport()tests were both doing same actions unintentionally. Modified the test to reflect the intentions.cancelAfterSuccessOnTransport()can either result in success or failure after the first request, modified test to verify the same.Result
Fix tests.