Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion scripts include completion for hidden subcommands, effectively unhiding them #442

Closed
2 tasks done
bjo0 opened this issue Apr 18, 2022 · 0 comments · Fixed by #443
Closed
2 tasks done

Completion scripts include completion for hidden subcommands, effectively unhiding them #442

bjo0 opened this issue Apr 18, 2022 · 0 comments · Fixed by #443

Comments

@bjo0
Copy link

bjo0 commented Apr 18, 2022

Completion scripts for zsh (--generate-completion-script) include completion for hidden subcommands, making them not very hidden.

I don't think this is a regression. In my testing, hidden arguments were correctly hidden in completion.

Checklist

  • If possible, I've reproduced the issue using the main branch of this package
  • I've searched for existing GitHub issues

Steps to Reproduce

  • create a command with subcommands
  • make one of the subcommands be hidden
  • generate and load completion for the command in your shell of choice (I used zsh)
  • navigate through the completion options for the base command

Expected behavior

Hidden subcommands should not be displayed.

Actual behavior

Hidden subcommands get displayed.
rauhul added a commit that referenced this issue Apr 23, 2022
@rauhul
Hide hidden subcommands from completions
4174530 
- Adds a filter to prevent hidden subcommands from appearing in shell
  completion scripts.

Fixes #442, rdar://92182881
@rauhul rauhul mentioned this issue Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide hidden subcommands from completions apple/swift-argument-parser
1 participant
@bjo0