-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine completion script tests #699
Conversation
Removes a ton of redundant completion script tests and combines unique components into a single common set of tests.
@swift-ci test |
@rgoldberg heads up |
@rauhul @natecook1000 Looks like you guys might be getting ready to release a new version. Any chance of discussing the issue mentioned in the comments of #679? Thanks for the heads up about this change. |
@swift-ci test macOS |
@rgoldberg We're happy to take PRs to improve these things, I dont know nearly enough about the completion stuff to have many opinions here |
@rgoldberg My goal is to move all these generators to using ToolInfo instead of the raw internals of argument parser. ToolInfo is basically our easier to use IR for the command structure. |
@rauhul thanks for the info. I've already made many changes in my local branch using the Is there anyone else besides @natecook1000 with whom I should discuss #679? |
Lets continue this discussion on #695. We'd love improvements in this area. Its important for evolution to decouple all these generators from the internals to a more stable API (ToolInfo) |
Removes a ton of redundant completion script tests and combines unique components into a single common set of tests.