-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Motivation We should feel confident that we compile clean under the strict checks of Swift 6. As this is a data-processing-only framework it's not a surprise that it turns out to be fine, but this patch adds the necessary docker-compose steps to ensure it continues to work. Modifications - Add docker-compose file for Swift 6 nightlies - Extend docker-compose to pass explicit sendable and strict concurrency checks - Add those checks to 6.0 and main nightlies Result Better confidence that we don't break our downstreams in Swift 6 support.
- Loading branch information
Showing
12 changed files
with
36 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,6 @@ let benchmarks = { | |
.readSyscalls, | ||
.writeSyscalls, | ||
.memoryLeaked, | ||
.retainCount, | ||
.releaseCount, | ||
] | ||
) | ||
|
||
|
4 changes: 1 addition & 3 deletions
4
...ks/Thresholds/5.10/SwiftASN1Benchmark.Parse_WebPKI_Roots_from_PEM_to_PEMDocument.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
{ | ||
"mallocCountTotal" : 960, | ||
"mallocCountTotal" : 976, | ||
"memoryLeaked" : 0, | ||
"readSyscalls" : 0, | ||
"releaseCount" : 13983, | ||
"retainCount" : 12200, | ||
"writeSyscalls" : 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...rks/Thresholds/5.8/SwiftASN1Benchmark.Parse_WebPKI_Roots_from_PEM_to_PEMDocument.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
{ | ||
"mallocCountTotal" : 960, | ||
"mallocCountTotal" : 976, | ||
"memoryLeaked" : 0, | ||
"readSyscalls" : 0, | ||
"releaseCount" : 17688, | ||
"retainCount" : 15905, | ||
"writeSyscalls" : 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...rks/Thresholds/5.9/SwiftASN1Benchmark.Parse_WebPKI_Roots_from_PEM_to_PEMDocument.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
{ | ||
"mallocCountTotal" : 960, | ||
"mallocCountTotal" : 976, | ||
"memoryLeaked" : 0, | ||
"readSyscalls" : 0, | ||
"releaseCount" : 13846, | ||
"retainCount" : 12063, | ||
"writeSyscalls" : 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...ks/Thresholds/main/SwiftASN1Benchmark.Parse_WebPKI_Roots_from_PEM_to_PEMDocument.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
{ | ||
"mallocCountTotal" : 960, | ||
"mallocCountTotal" : 976, | ||
"memoryLeaked" : 0, | ||
"readSyscalls" : 0, | ||
"releaseCount" : 13983, | ||
"retainCount" : 12200, | ||
"writeSyscalls" : 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
version: "3" | ||
|
||
services: | ||
|
||
runtime-setup: | ||
image: swift-asn1:22.04-6.0 | ||
build: | ||
args: | ||
base_image: "swiftlang/swift:nightly-6.0-jammy" | ||
|
||
test: | ||
image: swift-asn1:22.04-6.0 | ||
environment: | ||
- SWIFT_VERSION=6.0 | ||
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors | ||
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error | ||
- EXPLICIT_SENDABLE_ARG=-Xswiftc -require-explicit-sendable | ||
- STRICT_CONCURRENCY_ARG=-Xswiftc -strict-concurrency=complete | ||
# - SANITIZER_ARG=--sanitize=thread # TSan broken still | ||
|
||
shell: | ||
image: swift-asn1:22.04-6.0 | ||
|
||
update-benchmark-baseline: | ||
image: swift-asn1:22.04-6.0 | ||
environment: | ||
- SWIFT_VERSION=6.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters