Add support for parsing BER

[davidzech]

Adds support for parsing BER encoded structures.

• Refactor common ASN.1 structures to ASN1.swift, and move DER related items to DER.swift.
• Add BER.swift with full Parsing support
• Encoding to BER that is not also valid DER is not supported. Only DER will continue to be the only serialization strategy.

[dnadoba]

@swift-server-bot add to allowlist

[dnadoba]

Can you please run swift-format format --parallel --recursive --in-place Sources Tests? We use version 509.0.0.

We currently compile swift-format from source by cloning https://github.com/apple/swift-format and building it with swift build -c=release. Afterwards the binary is at .build/release/swift-format.

---

In addition you will need to run ./scripts/update_cmakelists.sh to add the new files to the cmake files list.

[davidzech]

Can you please run swift-format format --parallel --recursive --in-place Sources Tests? We use version 509.0.0.

We currently compile swift-format from source by cloning https://github.com/apple/swift-format and building it with swift build -c=release. Afterwards the binary is at .build/release/swift-format.

In addition you will need to run ./scripts/update_cmakelists.sh to add the new files to the cmake files list.

Fixed in 7a66b54

[davidzech]

Is this actually an API breakage?

14:27:58 5 breaking changes detected in SwiftASN1:
14:27:58   💔 API breakage: protocol ASN1IntegerRepresentable has generic signature change from <Self : SwiftASN1.DERImplicitlyTaggable, Self.IntegerBytes : Swift.RandomAccessCollection, Self.IntegerBytes.Element == Swift.UInt8> to <Self : SwiftASN1.BERImplicitlyTaggable, Self.IntegerBytes : Swift.RandomAccessCollection, Self.IntegerBytes.Element == Swift.UInt8>
14:27:58   💔 API breakage: protocol ASN1IntegerRepresentable has added inherited protocol BERImplicitlyTaggable
14:27:58   💔 API breakage: protocol ASN1IntegerRepresentable has added inherited protocol BERParseable
14:27:58   💔 API breakage: protocol ASN1IntegerRepresentable has added inherited protocol BERSerializable
14:27:58   💔 API breakage: constructor ASN1IntegerRepresentable.init(berIntegerBytes:) has been added as a protocol requirement

Am I wrong that this should be a transparent change to existing consuming code bases, since the new methods should have been satisfied with extensions.

[Lukasa]

You're correct, these are not breaking changes. The API breakage checker is just a bit pessimistic.

[Lukasa]

I'm happy with this, I'd like @dnadoba to confirm he is too.

[dnadoba]

Great addition! Thanks a lot for implementing this!