Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to compile without issue when ExistentialAny enabled #63

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

pseligman
Copy link
Contributor

Motivation:

We should feel confident that we compile clean when built in an environment that has enabled upcoming Swift features.

When compiling swift-asn1 specifying .enableUpcomingFeature("ExistentialAny") there are some minor warnings emitted by ASN1.swift.

Modifications:

Minor code changes to address surfaced warnings

Result:

Better confidence that we don't break downstreams that compile this code with these upcoming features enabled.

Unverified

No user is associated with the committer email.
Motivation:

We should feel confident that we compile clean when built in an environment
that has enabled upcoming Swift features.

When compiling swift-asn1 specifying `.enableUpcomingFeature("ExistentialAny")`
there are some minor warnings emitted by ASN1.swift.

Modifications:

Minor code changes to address surfaced warnings

Result:

Better confidence that we don't break downstreams that compile this code with
these upcoming features enabled.
@Lukasa
Copy link
Contributor

Lukasa commented Sep 14, 2024

@swift-server-bot add to allowlist

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Sep 14, 2024
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pseligman!

@Lukasa Lukasa enabled auto-merge (squash) September 14, 2024 06:52
@Lukasa Lukasa merged commit dd8cacc into apple:main Sep 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants