Update Swift targets to enable ExistentialAny #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: With the advent of Upcoming Feature Flags https://www.swift.org/blog/using-upcoming-feature-flags/ , we should make it a one-liner to enable feature flags. As a follow-on to PR 63, we should enable the ExistentialAny feature flag, as the code currently complies, and we may as well help flag any unintentional regressions to that behavior. Modifications: Update Package.swift to allow for one-liner additions of new feature flags. Enable the upcoming feature flag ExistentialAny Result: Better confidence that we don't break downstreams that compile this code with ExistentialAny enabled. Makes it (slightly) easier for future authors to modify the set of enabled feature flags.
Lukasa
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With the advent of Upcoming Feature Flags https://www.swift.org/blog/using-upcoming-feature-flags/ , we should make it a one-liner to enable feature flags.
As a follow-on to PR 63, we should enable the ExistentialAny feature flag, as the code currently complies, and we may as well help flag any unintentional regressions to that behavior.
Modifications:
Update Package.swift to allow for one-liner additions of new feature flags. Enable the upcoming feature flag ExistentialAny
Result:
Better confidence that we don't break downstreams that compile this code with ExistentialAny enabled.
Makes it (slightly) easier for future authors to modify the set of enabled feature flags.