Skip to content

Conversation

phausler
Copy link
Member

This resolves almost all of the warnings in the tests (except one).

@phausler phausler requested review from FranzBusch and kperryua June 23, 2023 19:20
@kabiroberai
Copy link

👋 hey @phausler, you might wanna have a look at swiftlang/swift#66934 which should fix the deprecation warning (given that there's not much you can do about it pre-stdlib-5.9). That said, it's worth noting that, iiuc, the ExecutorJob overload here will never be used since the UnownedJob variant is preferred. If my PR lands, it should hopefully be possible for you to remove the former until pre-5.9 platforms are dropped — or maybe gate it behind a !canImport(Darwin) conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants